Skip to content

Add uploader's username to package json API #1375

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 20, 2025

Conversation

Kleidukos
Copy link
Member

This gives the following payload:

{
    "author": "qwbarch",
    "copyright": "2021 qwbarch",
    "description": "Haskell package for easy integration with the 2captcha API.\n\nFeature list:\n\n* Lens-based API\n* Uses Wreq for http calls",
    "homepage": "https://github.com/qwbarch/2captcha-haskell#readme",
    "license": "MIT",
    "metadata_revision": 0,
    "synopsis": "Haskell package for easy integration with the 2captcha API.",
    "uploaded_at": "2022-09-24T05:49:45Z",
+    "uploader": "admin"
}

@Kleidukos Kleidukos requested a review from andreasabel April 1, 2025 12:04
@Kleidukos Kleidukos requested a review from gbaz April 1, 2025 12:52
@gbaz gbaz merged commit c43d7e4 into master Apr 20, 2025
13 checks passed
@gbaz
Copy link
Contributor

gbaz commented Apr 30, 2025

@Kleidukos I shouldn't have merged this. Testing reveals that it doesn't work, because it changes the statefile without creating a migration. But that said, why is there state at all? Can't we just have a lazy in-memory cache with no persistence? A refactor to do that would probably be easier, and appreciated.

@Kleidukos
Copy link
Member Author

@gbaz oh shit! I thought CI would have caught that. Of course locally it all worked perfectly…

What tools do we have at our disposal in the app for lazy in-memory caching? I must admit I am very unfamiliar with the backend's subtleties.

@gbaz
Copy link
Contributor

gbaz commented Apr 30, 2025

I mean literally just don't store this stuff in acid-state. store it in a map, and query it from the map.

@gbaz
Copy link
Contributor

gbaz commented Apr 30, 2025

on CI, yeah, we don't test from a dirty state, which would be a bit of engineering, but welcome, since it would catch this stuff!

@Kleidukos
Copy link
Member Author

I mean literally just don't store this stuff in acid-state. store it in a map, and query it from the map.

Aaah I see. :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants